Rockbox

great! I’ll check it as soon as I can…

A few general Comments. I will take a deeper look, when i find time.

- The patch isnt complete, all the unmodified files from PDa (and others) are missing in the patch. (you have to svn add them, to get them included into svn diff)
- You should add a README.rockbox which contains the details about the imported code (exact version, licence, etc) and your modifications.
- It would be a good Idea to divide that into a few patches. Like one patch for unmodified PDa (not enabled for compiling) then a patch (or many) with the different modifications needed for compiling, etc.

Here are the patches for dbestfit and PDa, both unmodified.

   dbestfit-initial.patch (65.9 KiB)
   pda-initial.patch.gz (753.4 KiB)

Wincent, the patch misses the addition into the rockbox make system (adding your patches doesn’t cause them to get build)

If I do that (see attached patch) it turns out this code doesn’t build and even misses some files:

CC apps/plugins/pdbox/pdbox.c
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/pdbox.c: In function `plugin_start’:
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/pdbox.c:102: warning: unused variable `mem_size’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/pdbox.c:103: warning: unused variable `mem_pool’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/pdbox.c:106: warning: unused variable `filename’ CC apps/plugins/pdbox/pdbox-net.c
CC apps/plugins/pdbox/PDa/src/m_fixed.c
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:2:24: sys/socket.h: No such file or directory
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:3:24: netinet/in.h: No such file or directory
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:4:25: netinet/tcp.h: No such file or directory
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:5:19: netdb.h: No such file or directory
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:25: warning: function declaration isn’t a prototype
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c: In function `ipod_connect’:
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:26: error: storage size of ‘server’ isn’t known
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: warning: implicit declaration of function `socket’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: error: `AF_INET’ undeclared (first use in this function)
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: error: (Each undeclared identifier is reported only once
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: error: for each function it appears in.)
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: error: `SOCK_DGRAM’ undeclared (first use in this function)
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:43: warning: implicit declaration of function `sys_sockerror’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:50: warning: implicit declaration of function `gethostbyname’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:50: warning: assignment makes pointer from integer without a cast
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:57: warning: implicit declaration of function `memcpy’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:57: error: dereferencing pointer to incomplete type
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:57: error: dereferencing pointer to incomplete type
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:59: warning: implicit declaration of function `htons’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:59: error: `u_short’ undeclared (first use in this function)
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:59: error: syntax error before “portno” /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:60: warning: implicit declaration of function `connect’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:63: warning: implicit declaration of function `sys_closesocket’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:26: warning: unused variable `server’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:31: warning: unused variable `intarg’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c: In function `ipod_bang’:
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:75: warning: implicit declaration of function `sprintf’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:76: warning: implicit declaration of function `send’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:76: warning: implicit declaration of function `strlen’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c: In function `pd_checkgui’:
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:111: warning: implicit declaration of function `strncmp’ /home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:112: warning: implicit declaration of function `strcmp’ make: *** [/home/peter/rockbox/gsoc/2009/dev1/build/apps/plugins/pdbox/PDa/src/m_fixed.o] Error 1

   add_to_subdirs.patch (0.3 KiB)

Here is the patch for the build system

   buildsystem.patch (1 KiB)

Here is the correct version of the pdbox initial patch

   pdbox-initial.patch (15.1 KiB)