- Status Closed
- Percent Complete
- Task Type Patches
- Category Rbutil
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#10221 - RBUtil doesn't install bootloader file at all
Verified with a fresh checkout of the source. When installing the bootloader (bootloaderinstallfile.cpp), the file is not copied to the target. Eg. w/ Gigabeat : the file FWIMG01.dat is renamed, but no new file is copied. And of course, the device won’t boot.
This is due to line being inverted in bootloaderinstallfile.cpp : the file is closed before being moved.
Attached a patch against 20987 to fix this bug.
Closed by Domonoky
2009-06-20 16:34
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-06-20 16:34
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Should be fixed with 1.2.2, if not,
please reopen.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Woops, added the whole file…
Woops, posted this in bugs while it should have gone into patches…
Are you sure this is the actual issue? From the documentation of QFile::rename() which is inherited by QTemporaryFile (http://doc.qtsoftware.com/4.5/qfile.html#rename):
The file is closed before it is renamed.
Thus from my understanding this change won’t make a difference here. What I’d like to see improved (might give it a go later today) is better error reporting: if the rename failed the user should get displayed an error instead of the current silent failure.
The original issue has also been reported here: http://forums.rockbox.org/index.php?topic=21614.0
You’re right.
Actually, it seems that everything works fine when building RBUtil from a fresh source.
Clément.
This really points looks like another bug in the newest Qt release (4.5.1).
We should really make a new build with a older Qt version for windows.
Clement: which version did you build? I.e. Windows, Linux, OS X? Which version of Qt did you use for building?
I had the same issue with Olympus MR-100 when installing the Rockbox bootloader with the Windows version of Rockbox Utility. I can try the Linux version in a few days if it’s helpful. The original firmware is moved to “/system/OF.mi4” but the Rockbox bootloader is not copied to “/system/PP5020.mi4” This was with version 1.2.1 downloaded from the wiki page.
Dominik: Built from svn checkout, with last Qt version (downloaded from the official website) under Linux.