• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Battery/Charging
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2009-05-22
Last edited by tomers - 2009-10-01

FS#10226 - isp1583.c code cosmetics

- Code cosmetics
- Use defined EP_CONTROL instead of 0 when applicable.

Closed by  tomers
2009-10-01 05:41
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r22866, including mcuelenaere's suggestions

Hmm I like most of the whitespace changes, but I don't like placing braces around single lines in if() structures.
Also I dislike your changes in the alignment when several parameters don't fit in one line (e.g. first part of @@ -195,15 +195,17 @@).

And AFAIK the Rockbox contribution rules prescribe: 'When changing code, follow the code style of the file you are editing.'


Available keyboard shortcuts


Task Details

Task Editing