• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Plugins
  • Assigned To
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by teru - 2009-05-25
Last edited by teru - 2010-09-25

FS#10241 - ovarlay loader for Lua is made while lua.ovl is not made.

Confirmed with r21075.
I build rockbox for myself and noticed that there is two “lua.rock”s.
One is “build-dir/apps/plugins/lua/lua.rock” and the other is “build-dir/apps/plugins/lua.rock”.
The latter seems to be a loader of lua.ovl, but lua.ovl doesn’t exist.

Closed by  teru
2010-09-25 14:57
Reason for closing:  Out of Date

This should be fixed in r24702, please confirm.

teru commented on 2010-02-17 12:55

the change doesn’t looks correct to me.
I think boomshine.lua needs to be surrounded by #if (PLUGIN_BUFFER_SIZE < 0×80000).
imho, it is better to comment out lua.c in SOURCES since currently lua doesn’t comile for lowmem target.

btw, i’m bit confused by comment and conditions.
comment in SUBDIRS says that Lua needs at least 160 KB to work in.
but condition is (PLUGIN_BUFFER_SIZE >= 0×80000). 0×80000 is more than 3 times 160K.
and now lua.c is added inside #if (PLUGIN_BUFFER_SIZE < 0×10000). what about targets where 0×10000 ⇐ PLUGIN_BUFFER_SIZE < 0×80000.

The comment saying Lua needs 160 kB to work in isn’t mine (I think it’s from safetydan), so I just left it in there.

The #if (PLUGIN_BUFFER_SIZE >= 0×80000) in SUBDIRS is wrong, that should be changed (if we can get the overlay to build, that is).

I don’t think boomshine.lua needs to be in an #if (PLUGIN_BUFFER_SIZE < 0×80000), unless there are targets that have less than 0×80000 audio buffer space?

Also, I just looked at apps/plugins/overlay.c and that mentions that the plugin shouldn’t use audio buffer, however Lua does (when it runs out of plugin buffer); so I’m not sure whether currently it’ll work on overlay targets.

Basically it comes to this: someone with a target running overlay plugins needs to take a look at this :)

teru commented on 2010-02-18 09:40

sorry my mistake. as for boomshine.lua, i intended #if (PLUGIN_BUFFER_SIZE >= 0×80000).
my point was that including lua scripts while it isn’t supported would confuse people.

teru commented on 2010-02-18 09:49

for overlay, pictureflow seems to use overlay and audio buffer same time, so if you are going to do something with overlay, maybe you can check it.


Available keyboard shortcuts


Task Details

Task Editing