• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pyro_maniac - 2009-05-27
Last edited by speachy - 2020-07-03

FS#10251 - plugin keymaps for Samsung YH-820 YH-920 YH-925

- First try of making plugin keymaps for Samsung YH-820 YH-920 YH-925

Closed by  speachy
2020-07-03 03:45
Reason for closing:  Accepted

Sry, there was an error on attching.

thanks for looking at this

"+#elif CONFIG_KEYPAD == SAMSUNG_YH_PA" shouldn't it be SAMSUNG_YH_PAD ?

Using the REC button should be discouraged, as it is actually a switch on 92x (like the hold switch) IMO.

some plugins make it easy to use switches.

example in rockblox:



Oh sorry, SAMSUNG_YH_PA is a copy and past misstake. i will rework that later.

And the REC button was only the first idea to have some.

I think we should commit early (as soon as all plugins build and have a keymap). We can fix bad keymaps later on a per-plugin basis.

I suggest we maintain a list of tested plugins here before committing, so we can be several people to test to go quicker.

This can be done before or after committing.

- fix typo "SAMSUNG_YH_PA"

You should also modify apps/plugins/lib/pluginlib_actions.c : some plugins use this list and don't have a list of per-target keymaps

EDIT: you also need to enable plugins in tools/configure

by the way the rec switch to exit plugins (tested cube) is not very user friendly :)

i edited tools/configure and apps/plugins/lib/pluginlib_actions.c. I don't have an idea for the rec switch right now.

The last patch wasn't tested enough. Sorry for that. This one should completly compile and work.

- fix remaining errors
- add missing defines

Heres an updated version. I think all thats missing is pacbox and the menu button for rockboy (couldn't see how to do this without owning the unit).

If someone fixes this I'll commit.

I've committed this patch, although keymaps are still a little rough and karl informs me that I've broken his recent blackjack clean up, so I'll leave this open. I'd appreciate someone going through these plugins and letting me know if any of the buttons aren't physically workable.


Available keyboard shortcuts


Task Details

Task Editing