Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Database
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by kugel. - 2009-05-30
Last edited by kugel. - 2011-12-22

FS#10263 - Pictureflow: start playback and integrate into databse's album note

This patch adds pictureflow to the database’s album note to start it.

Additionally it makes you able to start playback within pictureflow. It does so by creating a new playlist and starting it (overwriting the current one).

It doesn’t feature the context menu though (i.e. no insert/queue actions). That can hopefully be added to pictureflow later.

It works pretty well for me. Tell me if it’s committable (I hope it is :D )

Closed by  kugel.
2011-12-22 15:38
Reason for closing:  Out of Date
Additional comments about closing:  

The playback contro and "go to wps from pf" parts are in SVN, but not the database part (and the solution here is not committable). A new task for that can be openend if wanted.

Slight change in the fn offset logic, and also remove some debug statements. No functional change.

Re-use the old playlist if one didn’t leave the tracklist inbetween.

Works nicely for me. Some obvious things I already mentioned on IRC:

Backlight time out settings are ignored (meaning quickly drained battery if you use this for playback)
No easy way to get to WPS (though I understand you have a fix for this)

Otherwise, very handy. Combined with JPEG support this works really well for me.

This adds support to go to the WPS directly by adding a new exit code for plugins which is handled by the core.

Needs keymap for most targets, but it also adds a menu item since this may not be possible for every target using a key.

Im very sorry, but when patching it gives me 5 hunk errors.. May you please resync this please.. It looks like a huuuge fix to a big annoyance (not selecting and playing songs in pictureflow)… thanxs in advance :)

The playback part is in SVN, you can actually start and control playback. This merely adds a half-baken database integration and the ability to jump to the wps from within pictureflow.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing