Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by dontmind - 2009-06-03
Last edited by kkurbjun - 2009-12-18

FS#10271 - automatically disable voice upon rockdoom startup

hi there,
attached is a simple fix to disable voice upon doom startup and re-enable it upon quitting rockdoom, in the fashion other plugins do it (e.g. mpegplayer).

tested succesfully on my ipod 5.5g.

   doom_disable_voice.patch (0.9 KiB)
Closed by  kkurbjun
2009-12-18 04:26
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Thanks!

funman commented on 2009-06-05 17:50
      if( result == -1 )
+ {
+ rb→talk_disable(false);
          return PLUGIN_OK; // Quit was selected

+ } 

      else

+ {
+ rb→talk_disable(false); 

          return PLUGIN_ERROR; // Missing base wads

+ } 

  }

You can just add rb→talk_disable(false); before if( result == -1 )

dontmind commented on 2009-06-05 18:54

ahm…, right ;-)

   doom_disable_voice_r2.patch (0.8 KiB)
dontmind commented on 2009-06-17 09:07

any chance of having this commited?
it’s a simple fix for a simple issue…

Thecoolgman commented on 2009-06-17 10:15

I think it should be compiled

Thecoolgman commented on 2009-06-17 10:15

I mean commited :P

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing