• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Playlists
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2009-06-06
Last edited by jdgordon - 2009-12-16

FS#10289 - Icons in the playlist viewer are not shown if the filetype icons are set to 'off'

Set the following settings:

‘Show icons’ in the theme settings to “No” ‘Show icons’ in the playlist viewer settings to “Yes”

Under this circumstances, I’d expect the marker of the current song in the playlist to be shown. The same for the marker of the moved song (while moving a song in the playlist). But the markers are not shown.

Tested with r21166 (not the latest today, but I think there were no code changes in this area)

Closed by  jdgordon
2009-12-16 08:37
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

better solution is to move the settings check out into the calling code… r24022.

nls commented on 2009-06-07 08:14

This happens because list_draw() checks the “Show icons” setting directly and doesn’t draw icons if that is set to no.
not sure how to fix that in a nice way though, a simple hack in that function could special case for the playlist viewer but, well it’s hacky
otherwise we might need to make the callers tell it if icons should be drawn or not…

fml2 commented on 2009-06-07 09:34

Or we could have two functions for drawing lists. One would work as the current one (since it’s used in most cases), and the other would have a parameter telling what to draw.


Available keyboard shortcuts


Task Details

Task Editing