• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Ubuntuxer - 2009-06-07
Last edited by Ubuntuxer - 2009-07-04

FS#10291 - Use lib highscore.h to save highscore and add new high score table

The following patch use the lib highscore.h to save highscore and add new high score table.
If you achieved an new highscore your rank in the list is highlighted.

Closed by  Ubuntuxer
2009-07-04 23:05
Reason for closing:  Accepted
teru commented on 2009-06-07 17:12

your patch seems to contain issue and a bit weird for me.
*level of the highest score is NOT always equal to the highest level beaten.
*”Highest” should be “highest”. but why don’t you just reuse “highscores” in struct game_context?
*your patch contains some tabs.
*is there any reason to remove bubbles_callback?
*i don’t see the reason for renaming NUM_SCORES and SCORE_FILE.

i divided it to two patchs.
*first patch is to make bubbles to use lib/highscore.c for highscores.
*second patch changes the way to display high scores. second patch depends on first one.
small change: draw line under score for non-colour targets in stead of highlighting.

Thank you for your review of my patch. I would change still the following things:
- set NUM_SCORES to 5 because a relative big font or a small display size comes to sysfont, which is very tiny and hard to read
- remove useless messages like “rb→splash(0, “Loading…“);” - just display “New High Score” not the position and a ugly “#” - the menu enty should be renamed from “Display High Scores” to “High Scores”;, because on a small display size the text have to horizontally scrolled
- underline last score doesn’t works, the line is covered by the letters in next row
Apart from that your patch works very well for me. Thank You.

I included the things, which I would change and fix the bug with underline last score.
If you accept it, I will commit the patch.

teru commented on 2009-06-21 04:53

If you tested it and thought it’s ok, i don’t object.
To be honest, I do not like the new highscore displaying as it can use sysfont or it possibly displays agly table depending on font and screen size.

For that reason I changed NUM_SCORES to 5, so that sysfont is used less often and just on very small screen size.

I detected your task  FS#10350 , which change the behaviour of lib/highscore.h, expecially update_highscore() fundamental.
Your patch seems to work fine for me. But the patch “bubbles_highscore2.diff” just works with the old lib/highscore.h, so I will review your patch on  FS#10350  and I will adapt my bubbles patch to it.

I synced the patch to the current svn; no functional changes.


Available keyboard shortcuts


Task Details

Task Editing