- Status Closed
- Percent Complete
- Task Type Patches
- Category Drivers
- Assigned To No-one
- Operating System Another
- Severity Low
- Priority Very Low
- Reported Version Version 3.2
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#10309 - Sansa AMS : correctly sets timeout for data access
Sets MCI_DATA_TIMER to a correct value (100ms for read, 250ms for write)
We should also calculate a timeout given what the card CSD reports, and take the lower between the calculated value and 100/250ms.
The OF doesn’t seem to do that so we just save some calculations at each boot and µSD insertion.
In the same process I started removing the duplicate tSDCardInfo structure and putting the 2 needed struct members into tCardInfo (designed for MMC iiuc).
I also let some crude debug code into the isr to detect infinite loops (I actually detected a timeout - status 0×8 - and I started working on this patch)
TODO:
- check if speed calculation is correct (didn’t bother)
- modify ata-sd-pp.c (tSDCardInfo → tCardInfo) - can wait release branching since we are now frozen
ams-sd-timeout.diff
(12.8 KiB)
2009-06-11 17:17
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
use sd_max_write_timeout for bank
selection (the attached patch was wrong
about that)
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Simpler patch : only MCI_DATA_TIMER changes.
I wanted to use the tCardInfo struct because it has tsac & nsac members, but these are not used by Sansa OF so I just ignored them and used the default timeout mentioned in SD spec