Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mcuelenaere - 2009-06-11
Last edited by mcuelenaere - 2009-06-13

FS#10314 - Set Rockbox SVN root svn:ignore keyword to ignore build directories

This patch adds build* and output directories to the svn:ignore property of the Rockbox SVN root folder.

Closed by  mcuelenaere
2009-06-13 17:51
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r21277.

if they are used by release scripts then it's useful

I think it's useful because I name my build directories build1, build2, build3, etc.. and put them inside the SVN root (and don't want them to show up in svn status); I'm not sure how others handle this so that's why I posted a patch instead of committing it directly to SVN.

if they are used by release scripts then it's useful

I'm not sure what release scripts you're talking about ? (tools/release/* ?)
If so, they use build-<target_name> as temporary build directories and output as output directory (hence I also added output to svn:ignore).

I think this is useful, regardless of release scripts. The wiki tells you to create a build folder called "build" and I bet most people will use this or some "build-<something>" naming. The only thing that looks pointless to me is the patch itself – as far as I know there's no way to make patch apply property changes. Or did I miss something here?

Maurus, yes i meant these scripts (i use out of tree build directories)

Dominik, I understood that the "patch" was there only for comments

Dominik: hmm yes, I hadn't thought about the fact that 'patch' doesn't do anything to the svn metadata..

I'll just commit it then as no-one seems to object.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing