Rockbox

Tasklist

FS#10323 - Add Left button in addition to Select button for the USB charging only action

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Friday, 12 June 2009, 14:23 GMT
Last edited by Paul Louden (Llorean) - Friday, 12 June 2009, 16:48 GMT
Task Type Patches
Category Manual
Status Closed
Assigned To No-one
Operating System Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The e200 manual says:
"3.3 Charging - The player can be powered over USB without connecting to your computer by holding Select while plugging in. This allows you to continue using the player normally."

I found it very inconvenience to use the Select button. For example, when the user is on the main menu and would like to attach the e200 DAP to USB port for charging only, he has to press the Select button and thus enter the main menu's context menu.

I think the allowing the Left button in addition to the Select button for the USB charging action is a good solution for this issue, as it doesn't perform any action while in the main menu. The left button, TMHO, is more convenient to press than the Select button, and it is also more intuitive and consistent, since that button is also used for loading the OF during boot.

The attached patch adds the Left button as an action button for USB charging only mode. It also updates the e200 manual.

As the file firmware/usb.c is changed, I would like users of other targets to verify it doesn't introduce any issue. Users of other targets should consider setting more buttons for this action.
This task depends upon

Closed by  Paul Louden (Llorean)
Friday, 12 June 2009, 16:48 GMT
Reason for closing:  Rejected
Additional comments about closing:  The "select" button doesn't do anything, it just changes screens. In EVERY screen except the root of the menu structure, left moves to another screen as well, and in some screens can even change the playback state of the player.

As well, please search for similar tasks, there's already a patch on the tracker allowing you to use any button as the charge-only action, rather than just one or two preset ones.
Comment by Maurus Cuelenaere (mcuelenaere) - Friday, 12 June 2009, 14:53 GMT
You seem to have forgotten to attach your diff? :)
Comment by Tomer Shalev (tomers) - Friday, 12 June 2009, 16:20 GMT
> You seem to have forgotten to attach your diff? :)
I can swear I selected the patch previously :-)

Loading...