• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by torne - 2009-06-14
Last edited by torne - 2009-10-16

FS#10330 - pluginlib: xlcd_scroll_* functions should clear screen for high scroll count

The xlcd_scroll_* functions in pluginlib check if the pixel count to scroll is more than the relevant screen dimension, and if so they do nothing. This seems wrong: if you ask to scroll up by LCD_HEIGHT - 1 then it clears all the lines of the screen except the top, so scrolling by LCD_HEIGHT or more should logically just clear the entire screen.

Attached patch makes them call lcd_clear_display() instead of doing nothing.

The greylib scroll functions have the same bug, but the fix is not so trivial, and I've not delved into how greylib works..

Closed by  torne
2009-10-16 20:18
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Submitted in r23211

torne commented on 2009-10-16 19:53

Updated to include greylib, and to include the new xlcd packing mode.


Available keyboard shortcuts


Task Details

Task Editing