- Status Closed
- Percent Complete
- Task Type Bugs
- Category Plugins
- Assigned To No-one
- Operating System Sansa e200
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#10331 - mpegplayer deadlocks since r21258
r21257 - mpegplayer works
r21258 - mpegplayer deadlocks when starting video - tested with elephantsdream-q6-224×176-496kbps.mpg
Closed by pondlife
2009-06-15 15:49
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-06-15 15:49
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Should be resolved in r21293 .
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Is this with an e200v1 or e200v2?
Both e200v1 and e200v2 fail.
svn r21258 was the commit of
FS#8894- speeding playback up/down without affecting pitchAfter playback, mpegplayer will work. It’s fs#8894’s bug.
Does this happen if you’ve left timestretch disabled, or only if you’ve enabled it?
It happens even if you leave timestretch disabled. It’s never been turned on for my e200, but the problem occurs.
I’m not in a position to test right now, but does the attached patch fix?
No, this patch does not fix the problem, it still deadlocks. As Lee said, if will work if you play a music track first.
I think we had a very similar problem when MP3-on-COP was committed (mpegplayer dead-locks if there was no playback before[although I’m not sure if playing something back really made it work, but that’s how I remember the problem]). I can’t recall the details anymore though, so maybe ask saratoga.
OK, this seems to fix it for me. Basically, we relied on dsp_output_count() being called to set up the sample buffers, now it’s done in dsp_configure() instead.
Also split the tdspeed.c start-up initialisation into it’s own routine to be more like other modules.
This one seems to work fine for me on e280v2. Playback starts right up if it’s the first thing I go to.