FS#10338 - Add "use morse input " entry to settings menu
Attached to Project:
Rockbox
Opened by David Johnston (animatorgeek) - Monday, 15 June 2009, 16:05 GMT
Last edited by Teruaki Kawashima (teru) - Sunday, 08 November 2009, 13:29 GMT
Opened by David Johnston (animatorgeek) - Monday, 15 June 2009, 16:05 GMT
Last edited by Teruaki Kawashima (teru) - Sunday, 08 November 2009, 13:29 GMT
|
DetailsThis patch adds an entry to the settings menus to set whether the user wants to use the morse code text input screen rather than the main keyboard screen. An entry in the general_settings struct now holds the current morse input bool.
As a result of this change, whenever the user changes between the morse and standard text input screens -- either through the menu or the key combo while inputting text -- Rockbox will remember that setting across sessions. This makes the menu item a somewhat redundant feature, but still valuable since it doesn't require remembering an obscure key combination to change text input style. I applied this patch to revision 21293, but should be generally applicable. |
This task depends upon
Closed by Teruaki Kawashima (teru)
Sunday, 08 November 2009, 13:29 GMT
Reason for closing: Accepted
Additional comments about closing: Committed in r23567.
Sunday, 08 November 2009, 13:29 GMT
Reason for closing: Accepted
Additional comments about closing: Committed in r23567.
But yeah, changing it to get rid of the menu item is totally an option. It's hard to get a feel about whether anyone else has an opinion about how this should work. At any rate, it would be nice if _at least_ the input choice was persistent.
* Move relevant defines to settings.h and the other defines to keyboard.c
* Add option item to change the setting under "Settings -> General Settings -> System"
* Enable morse input for some targets that doesn't have key to change mode in the keyboard
- Needs to change the setting under "Settings -> General Settings -> System" to change input mode for these targets.
* move #define HAVE_MORSE_INPUT to config-*.h