FS#10338 - Add "use morse input " entry to settings menu

Attached to Project: Rockbox
Opened by David Johnston (animatorgeek) - Monday, 15 June 2009, 16:05 GMT
Last edited by Teruaki Kawashima (teru) - Sunday, 08 November 2009, 13:29 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This patch adds an entry to the settings menus to set whether the user wants to use the morse code text input screen rather than the main keyboard screen. An entry in the general_settings struct now holds the current morse input bool.

As a result of this change, whenever the user changes between the morse and standard text input screens -- either through the menu or the key combo while inputting text -- Rockbox will remember that setting across sessions. This makes the menu item a somewhat redundant feature, but still valuable since it doesn't require remembering an obscure key combination to change text input style.

I applied this patch to revision 21293, but should be generally applicable.
This task depends upon

Closed by  Teruaki Kawashima (teru)
Sunday, 08 November 2009, 13:29 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed in r23567.
Comment by Alexander Spyridakis (xaviergr) - Monday, 15 June 2009, 16:20 GMT
I think you forgot to upload the patch. :P
Comment by David Johnston (animatorgeek) - Tuesday, 16 June 2009, 03:59 GMT
Oops, I could have sworn I had attached it. Here it is now:
Comment by Jonathan Gordon (jdgordon) - Friday, 03 July 2009, 04:39 GMT
looks fine except adding a whole menu for 1 setting is not good.... just place it somewhere logical
Comment by Steve Bavin (pondlife) - Friday, 03 July 2009, 09:23 GMT
I know nothing about morse input, but wonder if you need a menu item at all - could it not just remember the last selected mode?
Comment by David Johnston (animatorgeek) - Saturday, 04 July 2009, 02:34 GMT
That's a good point, though part of the reason I wanted to have a menu item is that it's really hard to remember the button shortcut for switching to the morse screen (at least on the h120) if you haven't used it in a while.

But yeah, changing it to get rid of the menu item is totally an option. It's hard to get a feel about whether anyone else has an opinion about how this should work. At any rate, it would be nice if _at least_ the input choice was persistent.
Comment by David Johnston (animatorgeek) - Saturday, 04 July 2009, 02:35 GMT
And yeah, I agree, adding a whole menu for one setting is rather extreme. I looked around and I didn't find a place where I thought it would fit with the other entries. I'll take a look again.
Comment by David Johnston (animatorgeek) - Sunday, 05 July 2009, 05:40 GMT
Okay, here's a new version. I got rid of the menu entry entirely. Now it just remembers which input mode you last used.
Comment by Gman (Thecoolgman) - Monday, 13 July 2009, 23:36 GMT
Hi I get the following error on my my 5th gen using this patch (see the image) yes I have used a clean build on this patch.
Comment by Teruaki Kawashima (teru) - Saturday, 22 August 2009, 13:23 GMT
Make the change bit general. not tested well.
* Move relevant defines to settings.h and the other defines to keyboard.c
* Add option item to change the setting under "Settings -> General Settings -> System"
* Enable morse input for some targets that doesn't have key to change mode in the keyboard
- Needs to change the setting under "Settings -> General Settings -> System" to change input mode for these targets.
Comment by Teruaki Kawashima (teru) - Tuesday, 06 October 2009, 14:00 GMT
Sync to r22983.
Comment by Teruaki Kawashima (teru) - Friday, 06 November 2009, 14:08 GMT
update patch.
* move #define HAVE_MORSE_INPUT to config-*.h