FS#10360 - Recording settings aren't saved when changed on the recording screen

Attached to Project: Rockbox
Opened by David Johnston (animatorgeek) - Sunday, 21 June 2009, 08:19 GMT
Last edited by Frank Gevaerts (fg) - Thursday, 17 December 2009, 22:59 GMT
Task Type Patches
Category Recording
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


This bug currently exists as of rev 21444.

If settings are modified on the recording screen they aren't persistent after a reboot unless another setting is changed somewhere in the menu system.

The problem is that global_settings is being modified without a subsequent call to settings_save().

Attached is a fix for this problem. I've so far only tested it on the h1x0 simulator but I think it's a pretty benign change, unlikely to cause problems on other targets.
This task depends upon

Comment by Alexander Levin (fml2) - Wednesday, 01 July 2009, 22:11 GMT
Just a quick question: are the changes made in the screen supposed to be persistent? Or are they supposed to be transient (persist up to power off), and only the changes made through the settings should be persistent? I don't know, just asking.
Comment by David Johnston (animatorgeek) - Thursday, 02 July 2009, 00:42 GMT
I suppose that's a good question. Either way, there's a bug. If you change a setting via the recording screen it will be saved if you also change a setting somewhere else (like via an entry int the menu system), but otherwise it won't. Anyway, personally I feel like I want those settings saved, so that's the fix I made (not to mention that it's the easier fix). I feel that things like this are best if they maintain a persistent experience -- that I can be confident that it'll be the way I left it.
Comment by Peter D'Hoye (petur) - Friday, 03 July 2009, 16:45 GMT
this has always been like that.

IF we want this changed by saving the settings THEN it should only be done when leaving the screen, not on every change!
Comment by David Johnston (animatorgeek) - Saturday, 04 July 2009, 02:37 GMT
What difference does it make whether it's saved on every change or just when leaving the screen? Is it a battery saving issue? If so, I suppose that's a good point.
Comment by David Johnston (animatorgeek) - Sunday, 05 July 2009, 05:31 GMT
Okay, I think I got it to a better state. It now only saves settings when exiting the recording screen (and, on targets with F keys, on exiting the f2 and f3 menus).

This is still the changes-on-the-recording-screen-are-persistent version. The notion of making them consistently non-persistent is another question which doesn't have a clear answer. Is this something it would be appropriate to ask about on the dev list?