Rockbox

  • Status Unconfirmed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Recording
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by animatorgeek - 2009-06-21
Last edited by fg - 2009-12-17

FS#10360 - Recording settings aren't saved when changed on the recording screen

This bug currently exists as of rev 21444.

If settings are modified on the recording screen they aren't persistent after a reboot unless another setting is changed somewhere in the menu system.

The problem is that global_settings is being modified without a subsequent call to settings_save().

Attached is a fix for this problem. I've so far only tested it on the h1x0 simulator but I think it's a pretty benign change, unlikely to cause problems on other targets.

   recording_config_save_fix.diff (8.1 KiB)
fml2 commented on 2009-07-01 22:11

Just a quick question: are the changes made in the screen supposed to be persistent? Or are they supposed to be transient (persist up to power off), and only the changes made through the settings should be persistent? I don't know, just asking.

animatorgeek commented on 2009-07-02 00:42

I suppose that's a good question. Either way, there's a bug. If you change a setting via the recording screen it will be saved if you also change a setting somewhere else (like via an entry int the menu system), but otherwise it won't. Anyway, personally I feel like I want those settings saved, so that's the fix I made (not to mention that it's the easier fix). I feel that things like this are best if they maintain a persistent experience – that I can be confident that it'll be the way I left it.

petur commented on 2009-07-03 16:45

this has always been like that.

IF we want this changed by saving the settings THEN it should only be done when leaving the screen, not on every change!

animatorgeek commented on 2009-07-04 02:37

What difference does it make whether it's saved on every change or just when leaving the screen? Is it a battery saving issue? If so, I suppose that's a good point.

animatorgeek commented on 2009-07-05 05:31

Okay, I think I got it to a better state. It now only saves settings when exiting the recording screen (and, on targets with F keys, on exiting the f2 and f3 menus).

This is still the changes-on-the-recording-screen-are-persistent version. The notion of making them consistently non-persistent is another question which doesn't have a clear answer. Is this something it would be appropriate to ask about on the dev list?

   recording_config_save_fix_v2.... (9.5 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing