FS#10366 : Optional debug output for sound.c

Status Closed
Percent Complete
100%
Task Type Patches
Category User Interface → Simulator
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by Blue_Dude - 2009-06-22
Last edited by kugel. - 2009-06-22

FS#10366 - Optional debug output for sound.c

Replaces debug output with optional log output. Output is enabled by uncommenting a define statement. Disabled by default.

sound-logf.patch (1.7 KiB)

Closed by kugel.
2009-06-22 18:51
Reason for closing: Rejected
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed the last patch targetting a cleanup in r21467.

We agreed on not needing (=rejecting) the initial patch though.

Comments (4)
Related Tasks (0/0)

linuxstb commented on 2009-06-22 09:04

I tried to talk to you about this in IRC last night, but we missed each other. I asked why these patches don’t simply replace DEBUGF with logf and you replied a couple of hours later saying " There’s no problem with that, except it would be nice to turn off logf when not building for a simulator”.

By default, logf _is_ turned off when building for a real target. You need to explicitly enable it (in the Advanced options in configure, or by #defining ROCKBOX_HAS_LOGF in autoconf.h).

It doesn’t seem optimal that these patches (including the two that have been committed already) add yet another debugging macro (LOGFQUEUE).

Blue_Dude commented on 2009-06-22 12:42

This is true. But it’s also true that it’s easy to miss the enable define when building for a real target. The macro I put in is automatically disabled even if logf is mistakenly left active. OK, that’s pretty weak, but when I saw the macro construction in another file it seemed like a good idea.

I’ll modify the patches and post them here.

Blue_Dude commented on 2009-06-22 13:10

This should fix all of them.

logf.patch (3.1 KiB)

Blue_Dude commented on 2009-06-22 17:08

Upon further discussion, sound.c doesn’t need patching, but the other two need cleanup. Here’s the cleanup.

logf.patch (1.5 KiB)