FS#10378 - lua causes segfalts when loading a nonexisting file

Attached to Project: Rockbox
Opened by Daurnimator (daurnimator) - Wednesday, 24 June 2009, 10:16 GMT
Last edited by Maurus Cuelenaere (mcuelenaere) - Wednesday, 24 June 2009, 10:39 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Make a lua script that trys to load a non existing file, eg:

loadfile ( "/file" )
dofile ( rb.current_path ( ) .. "randomfile" )

run it; A segmentation fault occurs. (At least in my sim)

I've tried to narrow it down, and it seems to be causes at line 557 of apps/plugins/lua/lauxlib.c
"const char *filename = lua_tostring(L, fnameindex) + 1"
==> if you take away the +1, it works, but I think that would change what its pointing too....
This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Wednesday, 24 June 2009, 10:39 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r21488.
Comment by Maurus Cuelenaere (mcuelenaere) - Wednesday, 24 June 2009, 10:32 GMT
That code isn't ours, so I think this should also get reported upstream.

This seems like it's a mistake in my code, I'll look into it