- Status Closed
- Percent Complete
- Task Type Patches
- Category Plugins
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by daurnimator - 2009-06-24
Last edited by mcuelenaere - 2009-06-28
Opened by daurnimator - 2009-06-24
Last edited by mcuelenaere - 2009-06-28
FS#10379 - Fix lua coding style
Fixed lua coding style in helloworld and test_viewports:
optimised some code, made it more readable
Closed by mcuelenaere
2009-06-28 14:55
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-06-28 14:55
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
In r21541.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Most of these changes are whitespace changes, which I’m not inclined to accept; see the Rockbox guidelines for more information: http://svn.rockbox.org/viewvc.cgi/trunk/docs/CONTRIBUTING?view=markup
I will probably commit some of the functional changes when I’ll remove the current way to access files and replace it with the Lua IO library, but I’ll need your real name for that (again, see the guidelines).
oh well,
You can do what you want, I just thought it was very unreadable.
Well, I don’t agree with you :)
Anyway, I will commit the functional changes; but as I said I need your real name for that.