• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Configuration
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rasher - 2009-06-28
Last edited by fml2 - 2009-06-29

FS#10392 - settings.c:set_file function should'nt modify filename argument

This simple patch stops set_file from modifying the filename argument.

Line 1157 sets the last / to \0, to split the filename variable into dir and basename. However, the dir part is only used in the following statement: strncasecmp(ROCKBOX_DIR, filename ,strlen(ROCKBOX_DIR)

Here, the comparison will be either true or false even without splitting the filename variable into dir part and basename part. I suspect it was previously doing a “dumber” comparison, and someone changed it to use strncasecmp, and didn’t see this issue.

This is needed to fix a bug in  FS#10931  that would cause themes to not load at all.

The task blocks this from closing
ID Project Summary Priority Severity Assigned To Progress
10391 Rockbox  FS#10391 - Center on loaded theme  Very Low Low
Closed by  fml2
2009-06-29 14:26
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r21551.


Available keyboard shortcuts


Task Details

Task Editing