Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Battery/Charging
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Thomas Martitz - 2009-06-29
Last edited by Thomas Martitz - 2009-07-05

FS#10397 - mkamsboot: little code rewrite to have better output

This rewrites the code to extend the output of the (standalone) mkamsboot, so that OF version and model version (e.g. v4 for m200v4) are shown.

Closed by  Thomas Martitz
2009-07-05 02:33
Reason for closing:  Accepted
Additional comments about closing:  

Committed as of r21648. Thanks Rafael.

Thomas Martitz commented on 2009-06-29 20:27

See, I mixed fw_revision and hw_revision in 1 place :(

Rafaël Carré commented on 2009-07-01 21:19

s/clop/clip/ in mkamsboot.h

fw_version and hw_version should go in separate arrays since they don't change between different firmwares for a same model

If you want I can do it when i find some time

Thomas Martitz commented on 2009-07-01 21:20

I thought we agreed on doing this sort of cosmetics later :)

This patch is about giving more output (including OF version) which needs slight code changes.

Rafaël Carré commented on 2009-07-02 00:25

- Adds the changes mentioned.
- Change a bit the text of a string (Beginning to patch the firmware ⇒ Firmware patching has begun!)
- Add newlines after this string, and before last line of output

Is it ok for you?

Thomas Martitz commented on 2009-07-02 00:29

Surely it is ok, just make sure it still works! :)

Rafaël Carré commented on 2009-07-02 09:15

[INFO] Original firmware MD5 checksum match
[INFO] Model: Sansa Clip v2 (v2) - Firmware version: 2.01.32
[ERR] Model name "clv2" not found in rockbox.sansa
[ERR] Could not load rockbox.sansa

Normal since it was scrambled with "clip", but perhaps the message could be better.

Also perhaps the hw_revision could be merged into the model name ? "Sansa Clip v2 (v2)"

Thomas Martitz commented on 2009-07-02 11:05

I'd drop the v2 actually.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing