Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Yoshihisa Uchida - 2009-07-10
Last edited by Maurus Cuelenaere - 2010-02-20

FS#10424 - [wav codec] wav codec supports some ADPCM formats

wav codec supports the following ADPCM formats:

  1. Microsoft ADPCM
  2. Dialogic Oki ADPCM
  3. Yamaha ADPCM

It is necessary to apply the patch of  FS#10422 ,  FS#10423 .

Closed by  Maurus Cuelenaere
2010-02-20 12:04
Reason for closing:  Accepted
Additional comments about closing:  

In r24782.

alex wallis commented on 2009-07-14 14:32

this task appears to depend on other tasks according to the description, so perhaps this should also be made a dependency of them.

alex wallis commented on 2009-07-14 21:31

this patch will not apply, I have applied fs #10422 and fs #10423.

Yoshihisa Uchida commented on 2009-07-16 14:11

In my build environment, these patches apply success.

Please tell me the error message when the patch is applied.

My build environment
OS

  Linux
 Windows Vista + Cygwin

Source

 r21903
alex wallis commented on 2009-07-16 14:48

Hi. for fs #10432 the error when the patch is applied is
patching file apps/codecs/codecs.make
Hunk #1 FAILED at 78.
1 out of 1 hunk FAILED – rejects in file apps/codecs/codecs.make

that is the only file that has a problem.

The same error appears to happen on fs#10433.

I am running the latest svn code. It does have some patches on, but none of them touch the files yours do. I did try applying only your patches and still got problems.

MichaelGiacomelli commented on 2009-07-21 19:16

Hi, I emailed you last month about your patches to the email in your contact info. Did you get my email?

Yoshihisa Uchida commented on 2010-02-06 09:13

I am not good at anything by the current illness. Because I had recovered from the illness at last, I can restart this correction.
Please wait for a new patch for a while.

Yoshihisa Uchida commented on 2010-02-16 09:12

new patch applied.

changes:
- sync r24691
- seek process corrects.

  1. I corrected to seek to dialogic oki adpcm, non block header yamaha adpcm format wave file.

(Because the definition of get_seek_pos() had been changed, I changed all wave formats.)
- I changed ‘chunksize’ value for all wave formats.
- I changed set_formats(). (fmtops does not used.)

Yoshihisa Uchida commented on 2010-02-20 10:02

I commit this patch (see r24782) but I cannot close my task.
please close this task.

Maurus Cuelenaere commented on 2010-02-20 12:04
but I cannot close my task

Please ask for Flyspray developer rights in IRC.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing