Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System Gigabeat F/X
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by teru - 2009-07-13
Last edited by teru - 2009-08-01

FS#10435 - page up/down doesn't work properly if title is displayed.

In gigabeat f/x, you can scroll page up/down by pressing A+ UP/DOWN in list such as browser or playlist viewer.
but scrolling page up/down skips extra one line.
for example, open playlist by “Context Menu” → “Playlist” → “Ceiw “.
items from 1 to 19 will be displayed and 1st item will be pointed.
then, press A+DOWN and 21st item will be pointed.
imo, 20th item should be pointed.
if you simply press A+DOWN again, 23rd item won’t be shown.
the number would differ depending on lcd height and font.

this is because title is not taken account of when calcurating how many lines to skip.
here is a patch for this bug.

   gui_list_pgupdown_fix.patch (0.9 KiB)
Closed by  teru
2009-08-01 15:00
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r22082.

stripwax commented on 2009-07-23 13:15

In my opinion, after page down the 19th item will be highlighted, rather than the 20th. Maybe that's just my preference?

teru commented on 2009-07-29 15:23

Committed in r22082.

If i understand your comment correctly, attached patch would do what you want.
Maybe there can be a settings "overlap when page up/down"?
Anyway, i think it is nothing to do with the bug.

   list.diff (0.6 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing