• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Music playback
  • Assigned To No-one
  • Operating System SW-codec
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Blue_Dude - 2009-07-18
Last edited by Blue_Dude - 2009-08-12

FS#10446 - Prevent potential problems in dsp.c by allowing for 0 count function calls

There are a number of functions in dsp.c that operate with a do-while loop. Most of these are contingent upon the count argument being greater than zero. While this should always be true, these functions are not fault tolerant and will exhibit unwanted results if called with a count of zero. So I’ve changed these do-while loops to equivalent while loops.

I’ve also changed an unrelated comment mistake describing the nature of a replaygain variable.

Closed by  Blue_Dude
2009-08-12 20:25
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r22282

Oops. That one had some extra semi colons. This one works.

Actually, that comment is more appropriate at the right-shift in set_gain… (And ouch, I should’ve moved that comment :) ).

There was some concern that this patch may affect processing speed. After benchmarking with an improved test_codec, I can confirm that it does not affect performance.


Available keyboard shortcuts


Task Details

Task Editing