FS#10453 : WPS bitmaps (backdrop) corrupted with recent build.

Status Closed
Percent Complete
100%
Task Type Bugs
Category User Interface → Themes
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by PaulJam - 2009-07-20
Last edited by jdgordon - 2009-07-20

FS#10453 - WPS bitmaps (backdrop) corrupted with recent build.

Using current build r21979 on a H300 (with default settings) i noticed some WPS corruption (see attached screendump).
This does not happen in the uisimulator.

With daily build r21977 this does not happen. So the recent cuesheet changes seem to cause this.

dump 090720-110639.png (23.4 KiB)

Closed by jdgordon
2009-07-20 15:50
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

21982.

Comments (7)
Related Tasks (0/0)

idak commented on 2009-07-20 12:04

I think r21978 is the cause.

learman commented on 2009-07-20 13:14

See it on my e200 too. Cuesheet support not enabled.

learman commented on 2009-07-20 13:29

I suspect the function audio_finish_load_track in playback.c to be the cause. It puts a temporary struct cuesheet on the stack. That the struct is close to 50 kB large, and since the audio thread stack is 5 kB, there ought to be a pretty big stack overflow. Kind of surprised it doesn’t cause more problems. :)

Rockfan commented on 2009-07-20 14:26

The same thing here (Sansa e200).

learman commented on 2009-07-20 14:59

I disabled the bit of code with the struct cuesheet and that removed the WPS corruption.

mc2739 commented on 2009-07-20 15:16

There IS a stack overflow when cuesheet support is enabled and the current or next song has a cuesheet.

jdgordon commented on 2009-07-20 15:22

untested fix… try it out and commit if it works, or ill test after work today

cuesheet-fix.diff (1.4 KiB)