FS#10462 - WPS plumbing

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Friday, 24 July 2009, 05:58 GMT
Last edited by Jonathan Gordon (jdgordon) - Monday, 27 July 2009, 07:35 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This patch is an attempt to get the wps code more split up into the wps engine and the wps screen... What I'd like to see is for the WPS screen code to only have a single call into the wps engine code which is to do the drawing... likewise, the engine code should have absolutly nothing to do with playback and changing any state of anything..

This patch doesn't add or remove any code (except a couple of headers), it only moves code around a bit... feel free to suggest a better naming scheme

The next thing to do would be split gwps.h up into whats actually needed by external code (pretty much nothing but a wps_redraw() header) and whats needed by the engine code...

after that, gwps.c and gwps-common.c could be merged into one as they both now only deal with changing playback behaviour (there are a few functions which I wasnt sure right now where the best place for them was so there is a bit which could still be moved.)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Monday, 27 July 2009, 07:35 GMT
Reason for closing:  Out of Date
Additional comments about closing:  done in r22062
Comment by Maurus Cuelenaere (mcuelenaere) - Friday, 24 July 2009, 12:41 GMT
I think you forgot svn add'ing the new files?
Comment by Jonathan Gordon (jdgordon) - Friday, 24 July 2009, 15:55 GMT
grr... I did svn cp.. doesnt that add them automatically?