• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System SW-codec
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by dreamlayers - 2009-07-31
Last edited by dreamlayers - 2009-08-08

FS#10476 - FLAC bitrate calculation overflows with large files

While playing a 561,500,563 byte FLAC file in r22076 on a 5G iPod, I get some pauses when the buffer is being refilled.

Bitrate calculation overflows when the filesize is multiplied by 8. The calculated bitrate is incorrect and very low. This may be seen in “Show track info”. The bitrate is used to calculate the watermark, resulting in an unreasonably low watermark.

I’m attaching a patch which fixes the calculation both in the metadata code and the FLAC codec. The metadata code is responsible for the above observations.

Closed by  dreamlayers
2009-08-08 20:36
Reason for closing:  Fixed
Additional comments about closing:  

Fixed in r22211


Available keyboard shortcuts


Task Details

Task Editing