• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mc2739 - 2009-08-05
Last edited by mc2739 - 2011-08-20

FS#10488 - Doom - rotate directional keys when screen is rotated

This patch for the Doom plugin will rotate the directional keys to match the screen rotation.

Screen rotation in Doom is only available for targets where the screen height is greater than the screen width (e200, gigabeat f,x)

Also included is a patch for manual changes for the above and additional cleanup.

Closed by  mc2739
2011-08-20 01:14
Reason for closing:  Out of Date
teru commented on 2009-08-05 14:58

IIRC, rotate_screen is only defined for targets with portrait LCD.
so, i guess your patch would break other targets than e200 and gigabeat.
patch for manual seems to add rotate option for ipodvideo for which i don’t think screen rotation is supported.
or am i misunderstanding something?

this is my old patch tried to do same thing.

The key patch only changes the key mapping on targets that can rotate the display.

The manual patch is incorrect due to a copy/paste error. The corrected manual patch is attached.

Upon further review, you are correct, rotate_screen will not exist if the LCD is not portrait. This updated patch should not cause errors on other targets.

Update again to correct cut/paste & “in too much of a hurry” errors


Available keyboard shortcuts


Task Details

Task Editing