Rockbox

|   
  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Utils
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by federico pelupessy - 2009-08-08
Last edited by Bertrik Sikken - 2009-08-09

FS#10496 - read_image close file?

I am not sure about whether it is actually used somewhere, but shouldn't
read_image_file_offset also close the file?

   read_image.patch (0.4 KiB)
Closed by  Bertrik Sikken
2009-08-09 22:21
Reason for closing:  Fixed
Additional comments about closing:  

Function containing the bug has been removed in svn r22232, thanks for reporting.

Bertrik Sikken commented on 2009-08-08 15:15

I think your concern is valid, I can't see these files being closed anywhere.
Your patch will not work because the new code can not be reached.

The attached patch should fix that.

   read_image2.patch (1 KiB)
Bertrik Sikken commented on 2009-08-08 15:27

Hmm, on closer inspection, nobody seems to use that function so it's not causing any problems and we might just remove it altogether, see attached patch.
Maybe we should ask the original author first before removing.

   read_image3.patch (1.4 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing