• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Blue_Dude - 2009-08-09
Last edited by kugel. - 2009-08-12

FS#10502 - Adds DSP functionality to the test_codec plugin

This patch adds three menu items to the test_codec plugin. They mirror the existing three items but with DSP in the signal chain. Other than adding DSP processing, the menu items behave identically to the original menu items.

I’ve also included a bonus fix for dsp.c. There is no functional change, but I found when hunting a bug that putting the enum items in order helped troubleshooting immensely.

I also upnumbered the plugin API version.

Closed by  kugel.
2009-08-12 18:19
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Jeff committed it himself in r22279.

Oops, the plugin version was upnumbered by someone else to the same value before this patch was posted. This one upnumbers it again.

This version loops back to the menu after running the test, with a new menu option to quit. This allows quick comparisons of DSP/non-DSP speed tests, for example.

Forgot to include plugins/SOURCES. Fixed.

plugins/SOURCES should *not* be included, it would make test_codec compile everytime (for releases and current builds).

You are absolutely correct. I included it as a convenience to make it easier to test. When it comes time to commit, it shouldn’t be there.


Available keyboard shortcuts


Task Details

Task Editing