FS#10512 - Bookmarking doesn't behave correctly

Attached to Project: Rockbox
Opened by Jeffrey Goode (Blue_Dude) - Tuesday, 11 August 2009, 14:25 GMT
Last edited by Jeffrey Goode (Blue_Dude) - Wednesday, 12 August 2009, 20:26 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


With "Bookmark on Stop" settings "Yes - Recent only" or "Ask - Recent only" the behavior is unexpected. With "Yes", it asks, and with "Ask" it behaves like "Yes".

Also, when the recent bookmark list is set to "Unique only", it will create a new bookmark in the recent list regardless of whether a previous bookmark exists, and will also create a folder bookmark, not just a recent one.
This task depends upon

Closed by  Jeffrey Goode (Blue_Dude)
Wednesday, 12 August 2009, 20:26 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed in r22281
Comment by Jeffrey Goode (Blue_Dude) - Tuesday, 11 August 2009, 17:35 GMT
It appears that r22192 broke bookmarking. The original define list had a repeat value: BOOKMARK_ASK and BOOKMARK_UNIQUE_ONLY both had the value of 2. r22192 changed the defines to an enum which gave them different values. This patch changes them back to a repeat value. Bookmark.c might have something strange going on if it only behaves with a repeat value but it's working for now.