• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Blue_Dude - 2009-08-11
Last edited by Blue_Dude - 2009-08-12

FS#10512 - Bookmarking doesn't behave correctly

With “Bookmark on Stop” settings “Yes - Recent only” or “Ask - Recent only” the behavior is unexpected. With “Yes”, it asks, and with “Ask” it behaves like “Yes”.

Also, when the recent bookmark list is set to “Unique only”, it will create a new bookmark in the recent list regardless of whether a previous bookmark exists, and will also create a folder bookmark, not just a recent one.

Closed by  Blue_Dude
2009-08-12 20:26
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r22281

It appears that r22192 broke bookmarking. The original define list had a repeat value: BOOKMARK_ASK and BOOKMARK_UNIQUE_ONLY both had the value of 2. r22192 changed the defines to an enum which gave them different values. This patch changes them back to a repeat value. Bookmark.c might have something strange going on if it only behaves with a repeat value but it’s working for now.


Available keyboard shortcuts


Task Details

Task Editing