Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pamaury - 2009-08-11
Last edited by mtarek16 - 2009-09-19

FS#10513 - logf and logfdump fix

This patch fixes a (long standing ?) bug of logf which caused a misunderstanding of how exactly logfbuffer worked. This fix also contained a rollback of a previous fix of logfdump to accomodate the change (r22250).

Closed by  mtarek16
2009-09-19 13:46
Reason for closing:  Fixed
Additional comments about closing:  

Fixed in another task ( FS#10528 ).

Quick question, why dropping strcpy in favor of memcpy ? in the context of logf, imho, strcpy is better and clearer.

Because there are not equivalent in this context and because the implementation doesn't use zero-terminated strings in the buffer. For this reason str(l)cpy is not adapted: it copies a zero-terminated string. In fact, the original str(l)cpy was wrong, it did not implement the behaviour described at the beginning of the file in comments.
Anyway, this weird implementation of logf was dropped and has been replaced by a simpler one ( FS#10528 ).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing