- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Version 3.3
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Alexander Levin - 2009-08-18
Last edited by Maurus Cuelenaere - 2009-08-18
Opened by Alexander Levin - 2009-08-18
Last edited by Maurus Cuelenaere - 2009-08-18
FS#10539 - Change the order of "Left/Right" for the "Scrollbar position" setting
As of r22405, the setting "Scrollbar position" has the following options (in this order): Right, Left. IMO it would be more intuitive to have them in the order "Left, Right".
This makes necessary that the meaning of the "scrollbar pos" setting is changed. Now it is "false=right, true=left". This patch changes it to the opposite, i.e. "false=left, true=right".
(The setting is modeled with a boolean value, and such values are normally displayed in the order "false, true" in the menu.)
If someone has set the scrollbar position other than the default then the scrollbar will change its position after applying this patch.
(Edit: attach the actual patch)
scrbar_pos.diff
(3.1 KiB)
Closed by Maurus Cuelenaere
2009-08-18 22:42
Reason for closing: Accepted
Additional comments about closing:
2009-08-18 22:42
Reason for closing: Accepted
Additional comments about closing:
In r22414.
I'll look at this this evening, but I'm wondering whether BOOL_SETTING(0, scrollbar_position, LANG_SCROLLBAR_POSITION, false, "scrollbar pos", "left,right", LANG_RIGHT, LANG_LEFT, NULL) shouldn't be BOOL_SETTING(0, scrollbar_position, LANG_SCROLLBAR_POSITION, false, "scrollbar pos", "right,left", LANG_RIGHT, LANG_LEFT, NULL) ?
Do you mean the sequence of "left,right" vs. "right,left"? I don't think so, i.e. I think that the order in your patch was wrong. But I'm not 100% sure. A comment in settings_list.c for the macro would help much
But I believe those values should be stored in this order: value for false, value for true (see OFFON_SETTING).