Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#10544 : Add comment to the BOOL_SETTING macro; use that macro for OFFON_SETTING

Rockbox

Tasklist

FS#10544 - Add comment to the BOOL_SETTING macro; use that macro for OFFON_SETTING

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Tuesday, 18 August 2009, 14:55 GMT
Last edited by Alexander Levin (fml2) - Tuesday, 18 August 2009, 22:40 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The lack of comments makes the developer's work hard. Let's make it a little bit easier!

Since OFFON is a special case of BOOL, we should define the former via the latter.
   setting_list_bool.diff (1.5 KiB)
This task depends upon

Closed by  Alexander Levin (fml2)
Tuesday, 18 August 2009, 22:40 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed in r22413.
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 18 August 2009, 18:37 GMT
+1
Comment by Thomas Martitz (kugel.) - Tuesday, 18 August 2009, 18:45 GMT
go for it, not sure why you put it on the tracker :)

Loading...