Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Manual
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by BdN3504 - 2009-08-21
Last edited by BigBambi - 2009-09-20

FS#10553 - Viewports are not in the manual

Let’s change this. here’s a first effort i have been working on for three nights now. Please help me fix the \opts, i can’t figure out how to use them in combination with {example}, that’s why i put the examples in their own files.

Closed by  BigBambi
2009-09-20 16:58
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Accepted as part of r22756 - thanks!

oops, forgot the file. here it is.

fixed this myself. comittable in my eys, you got anything to add?

fixed problems as discussed in irc.

forgot to remove a paranthesis which broke a table: update!

It seems you mixed up charcell and monochrome displays. charcell doesn’t have wps-viewports or ui-viewports at all.

I also think that it’s a poor choice to have the RTC stuff in the example, the additional file it needs isn’t worth it.

I’d like to see an example for an “ordinary” unlabeled viewport as well.

removed rtc, excluded charcell.

Committable?

It’s a good idea to search the tracker before writing up something. Anyway,  FS#9934  might have something usable. If not, it should be closed and replaced by this.

Good idea indeed. i vaguely remember having searched and did not get any results… well anyways, i have attached a preview, and also updated to the new rbtabular already in last post. please point out any problems, if you find them.

forgot a closing paranthesis. broke the table for grayscale targets. update.

and the proper preview. man i don’t think that there has ever been someone coding so many errors into such a simple document.

Changed the wording slightly in grayscale conditional. Added a line about the end of viewports.

Added the UIviewports part.
Added %V tag to wps tags.
Fixed some minor glitches (no %s after opts, removed the obsolete %P tag in the WPS tags)

Oops, wrong commit last time: somehow copypasta did me wrong.

I’ll try and have a proper look later, but a couple of immediate thoughts: “‘s” is the possessive, “s” is the plural so in my opinion it should be |s not |’s - perhaps we can find a way to rephrase this slightly to avoid the issue :)

fgcolor and bgcolor - I know on the wiki it is like this, but it seems a little odd not to change them to fgcolour and bgcolour - they are just place holders showing you where to put other values, and I can’t see any reason to keep them with the US spelling instead of the correct (for the manual) UK..

There are a couple of other minor things like “the blanks fields” should be “the blank fields”, but as I say I’ll look properly later.

Either way, good effort thus far :)

thanks for the love.
fixed these small issues. had to think alot about what you were refering to with |’s, simply replaced “-’s” with “hyphens”.
Also, if you take a look at it, please take investigate in the repeat states. i took out an opt there because i don’t think a-b is restricted to any player. i can be wrong, but i asked this question on IRC several times and no one answered, so i simply took the initiative.

Taking the initiative is good, but in a separate patch please.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing