Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Plugins
  • Assigned To
    kkurbjun
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by HIllshum - 2009-08-28
Last edited by kkurbjun - 2009-12-18

FS#10568 - Brickmania Lasers not working properly

When playing brickmania, if one fires lasers from the paddle, then gets a ‘N’ or a ‘G’, those shots that were fired cease to work.

Closed by  kkurbjun
2009-12-18 03:37
Reason for closing:  Accepted
Additional comments about closing:  

Thanks!

Just remove the ‘if’ from line 1181. (r22636)
By the way, I think that this loop is monstrous and not effective.

A diff file, in case that someone will commit it.

I still think that this loop have to been rewritten.

   bm.diff (2.6 KiB)

Asael,

Thanks for the patch, I will try to take a look at this later today, but offhand I think the fix looks appropriate. I agree that the game loop could definitely be re-written; it is not exactly efficient.

That loop has been changed some, at that patch is out of sync. Bug still present however.

It’s still a simple wrong “if”.
try the attached file. (I didn’t check it)

   bm.c (82.4 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing