Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Jonathan Gordon - 2009-08-31
Last edited by Jonathan Gordon - 2009-09-02

FS#10576 - move sub/lines to skin buffer

this patch seems to “work”, but the debug output just looks very wrong.. also it crashes the sim if –debugwps is enabled…

(gdb) p *v→lines→next→sublines
$8 = {first_token_idx = 4, last_token_idx = 3, line_type = 0 ‘\0’,

time_mult = 0 '\0', next = 0x0}
Closed by  Jonathan Gordon
2009-09-02 03:59
Reason for closing:  Accepted
Jonathan Gordon commented on 2009-08-31 15:41

forgot to update this before going to bed… its slightly better but apparently crashes the ipod….

the wierd stuff with the token numbers above is because for blank new lines, the \n isnt stored as a token, so special handling is needed (not added yet)

Jonathan Gordon commented on 2009-09-01 01:08

updated to add some special handling for empty lines

Jonathan Gordon commented on 2009-09-01 07:00

probably a lost cause but anyway…. somehow curr_line is getting set to 0×1 or some other similarly stupid value during parseing… I havnt figured out where or why or how though :( an internets to the person who figures it out!

Jonathan Gordon commented on 2009-09-01 07:52

All glory to funman for figuring it out :D
apparently there is still an isue to figure out though :/

Jonathan Gordon commented on 2009-09-02 00:41

I’m not memset()ing the newly alloc buffers to 0’s which unfortunatly hides the real issue, but makes it work…

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing