Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System Sansa c200
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bertrik - 2009-09-05
Last edited by bertrik - 2009-09-13

FS#10586 - c200(v2): right button in time setting menu exits menu

Both on the c200 and the c200v2, a short press on the right button in the time setting menu (System / Time & Date / Set Time/Date) causes the player to exit the time menu instead of going to the next time item (e.g. hours → minutes). Holding the right button slightly longer does make the player go to the next time item.

To reproduce: go to menu System / Time & Date / Set Time/Date, briefly press the right button. The menu is exited (setting is accepted).

Possible cause:
Time menu buttons are handled by button context button_context_settings which defines ACTION_STD_NEXT as BUTTON_NONE→BUTTON_RIGHT and seems to inherit from CONTEXT_STD. However button context button_context_standard defines an ACTION_STD_OK as BUTTON_RIGHT→BUTTON_RIGHT|BUTTON_REL.
So a short press on the right button probably causes both a ACTION_STD_NEXT and a ACTION_STD_OK action, which makes it exit the time settings menu.

Probably related to the change in SVN r21373 ( FS#8824 )

Closed by  bertrik
2009-09-13 11:40
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as svn r22692

bertrik commented on 2009-09-05 03:22

Attached patch makes going left/right in the time settings menu work again. Not sure if this has any side effects, haven’t tested thoroughly yet.

   c200_time_buttons.patch (1.4 KiB)
bertrik commented on 2009-09-05 19:25

Attached patch is another way of solving it, this simply maps the offending combination to ACTION_NONE, so it no longer falls through in actions of button_context_standard.

   c200_time_buttons_v2.patch (0.5 KiB)
bertrik commented on 2009-09-07 18:13

A similar problem exists in the color adjustment screen (e.g.Theme settings / Colours / Line Selector Colours). A short press right seems to be interpreted as OK/Accept.

bertrik commented on 2009-09-13 11:36

Attached patch fixes both the time/date menu and the colour chooser screen by assigning ACTION_NONE to the release of button left or right in their respective context keymaps.

   c200_keymap.patch (1.4 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing