Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System iPod 5G
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by archivator - 2009-09-10
Last edited by teru - 2009-10-03

FS#10597 - Loadable keyboard layout rendered incorrectly

The first time you load a keyboard layout or start rockbox, the virtual keyboard is displayed properly. The next time you open it, however, it is rendered with a fixed width font and completely disregards the number of lines in the original file. Thus, it makes loadable layouts unusable.

I last tested with r22668 but this has been going on for a while now.

Closed by  teru
2009-10-03 14:51
Reason for closing:  Fixed
Additional comments about closing:  

Should be fixed in r22892.
Please open a new task if there is still issue.

Could you attach the .kbd file and a screendump that displays the problem? I’m using a custom layout and haven’t seen anything unusual in the virtual keyboard with the current build (r22675).

Here you go! 110823 shows the properly rendered keyboard, the next one - the incorrectly rendered one. Both taken on ipodvideo 32GB. I couldn’t reproduce this behavior in a sim.

teru commented on 2009-09-12 13:31

this hopefully fix issue.
it seems like that max width is set to the width of the ‘\n’ character when kbd_input is called first time after loaded the kbd.
but ‘\n’ in kbd_buf is replaced by the spaces filling the line later. and max width becomes smaller when kbd_input is called next time.

While the patch makes the virtual keyboard consistent (and properly rendered), it is now rendered with a different font (the UI one instead of the one I selected). I don’t find it that much of an inconvenience but it would be nice if it would render as it did previously (see attached screenshot for clarification; compare with 110823 above).

teru commented on 2009-09-13 01:51

I don’t think different font is used. the difference is margin between two characters decided by lagest width among characters in kbd.
adding wider character(e.g. tab) to .kbd file would render the virtual keyboard like 110823.

I won’t discuss the spacing until I’m sure I know what I’m talking about so let’s leave that for now.

There’s, however, another issue I noticed when using your patch - the input line gets cut off at the end of the keyboard layout, wasting almost half the screen space to the right. See screendump for clarification.

teru commented on 2009-09-26 14:00

Does this one fix the issue?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing