FS#10602 - Improve debugwps further

Attached to Project: Rockbox
Opened by robin (robin0800) - Saturday, 12 September 2009, 06:52 GMT
Last edited by Jonathan Gordon (jdgordon) - Friday, 18 September 2009, 05:22 GMT
Task Type Bugs
Category Simulator
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


r22672 Says......
Hopefully make the wps debug info more understandable... display tokens the same way they are displayed... i.e viewports->lines->sublines->tokens
has done a good job of improving debug messages one omission from this is the Vd tag is still appearing as a number and not a token
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Friday, 18 September 2009, 05:22 GMT
Reason for closing:  Fixed
Additional comments about closing:  in r22727
Comment by MohamedTarek (mtarek16) - Sunday, 13 September 2009, 01:09 GMT
Vd works for me as expected, eg. : Vdh would display " Viewport: 'h' " starting form the first column in display.
Comment by robin (robin0800) - Sunday, 13 September 2009, 06:17 GMT
Are you saying it also displays correctly in debugwps? because allthough working correctly For Vda,Vdb,Vdc and Vdd I see Vp97,Vp98,Vp99 and Vp100 Clearly the debugwps is not tokenising these.
Comment by MohamedTarek (mtarek16) - Sunday, 13 September 2009, 08:31 GMT
Yes, I've just tested them in the sim ,with debugging output for wps enabled of course.
Those couple of lines from wps_debug.c make me wonder why it isn't working for you :
indent = 0;
DEBUGF("Viewport: '%c'\n", skin_viewport->label);
Have you tried a clean build after an svn up ?