Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Kuma76 - 2009-09-25
Last edited by shotofadds - 2009-09-26

FS#10615 - Cowon D2 Touchscreen driver

This patch (my first one) makes the Cowon D2s touchpad usable. No unintended double touches anymore and only really, really, really rare wrong detections.

While reading the coordinates the touchpad is put into the idle mode, which somehow reduces wrong readings drastically but they still occur. To get rid of them each touch is red five times, the coordinates are sorted and the 3rd value is taken.
Additionally this patch adds a dead zone between buttons when the touchsreen is in button mode.

Try it out and let me know what you think!

Closed by  shotofadds
2009-09-26 17:34
Reason for closing:  Accepted
Additional comments about closing:  

In r22842 & r22843.

bkd11 commented on 2009-09-26 04:05

Nice work! The accuracy of the 3 x3 grid seems much better with this patch.

Many thanks for this. The accuracy is much improved, the “dead zone” around the 3×3 buttons is a real help, and because you put the touchscreen in ‘idle’ mode this also reduces CPU usage while the screen is pressed. Good stuff all round!

I will commit this with a couple of changes:

- the ‘dead zone’ is too large (3% works just as well and results in fewer frustrating “dead” presses)
- the comparator function can be replaced with a simple *(short*)a - *(short*)b
- use the TIME_AFTER macro instead of directly comparing ticks

Thanks!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing