Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Carsten Schreiter - 2009-09-25
Last edited by Rob Purchase - 2009-10-11

FS#10618 - CowonD2 EQ Menu Buttons

This patch changes the button assignment in the graphical EQ menu on a Cowon D2 like below and makes the EQ menu easier to use (of course in the 3×3 grid mode only).

TOP_MIDDLE, MIDDLE_RIGHT, BOTTOM_MIDDLE, MIDDLE_LEFT are to navigate through the EQ settings.

BOTTOM_LEFT and BOTTOM_RIGHT are to change settings (in that way the setting is visible when changing it)

TOP_LEFT is to leave the EQ menu.

Closed by  Rob Purchase
2009-10-11 15:29
Reason for closing:  Out of Date
Additional comments about closing:  

Part committed, part superceded by 10639

Thomas Martitz commented on 2009-09-25 17:37

Can you instead fix the eq screen to work with the touchscreen mode? We’re not really happy about the grid mode at all and rather see that removed in the long tern,

Rob Purchase commented on 2009-09-26 11:25

I had a look into this last night, thinking there must be a much simpler way to get this working than introducing a load of #ifdef’s. It turns out all the problems with the EQ screen were due to conflicts (duplicated mappings) in the existing touchscreen keymap.

The following patch makes it work properly using the existing controls (up, down, left, right, centre to change mode). I think it’s somewhat cleaner.

(ps. kugel is right, this screen really needs some re-work for the “real” touchscreen mode - so I’ll leave this task open after I commit the above)

EDIT: I removed too much, patch updated ;-)

   eq.diff (1.7 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing