Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by BobC - 2009-09-30
Last edited by Domonoky - 2009-10-19

FS#10627 - Introduce bootloader and target files for new target Lyre Proto2

This patch introduces a port for the Lyre prototype2 hardware. The patch includes a minimal bootloader which just displays the logo on the LCD and flashes LEDs.

This patch changes crt0.s which is shared with the Gigabeat F/X ports; otherwise no other ports should be affected. I don’t have access to Gigabeat players so a regression test needs performing on these players.

   lyre_proto2_part1b.patch (60.4 KiB)
Closed by  Domonoky
2009-10-19 18:15
Reason for closing:  Accepted
kugel. commented on 2009-09-30 16:02

What happened to renaming to mini2440? I’m strongly in favor of that.

Domonoky commented on 2009-09-30 17:04

Also this patch could need some clean-up.
Many of the copied files still contain gigabeat string.

Also if there are files which are very similar to gigabeat (like the lcd) we should reuse the code, and not make a copy of it.
At moment your lcd driver contains ifdefs for gigabeat but is a copy.
(To reuse the gigabeat lcd code you may have to move the gigabeat lcd driver one level up, and maybe rename it).

And why does this target need its own kernel target file ? are there many differences in this to the gigabeat ?

BobC commented on 2009-10-01 22:53

All good points, I will address the issues raised and submit a new patch in a few days.

BobC commented on 2009-10-04 17:24

Here is a summary of the changes for modified patch:

1) Model renamed from “lyre_proto2” to “mini2440”. All references renamed 

  accordingly.

2) Move code common to S3C2440 SoC from “s3c2440/gigabeat-fx” to 

  "arm/s3c2440" dir. 
  
  Moved files are :
  kernel-meg-fx.c   -> ../kernel-s3c2440.c
  lcd-meg-fx.c      -> ../lcd-s3c2440.c
  system-meg-fx.c   -> ../system-s3c2440.c
  system-target.h   -> ../system-target.h

3) Improved porting of modules for Mini2440 - 

  mini2440/adc-target.h
  mini2440/backlight-mini2440.c
  mini2440/backlight-target.h
  mini2440/button-mini2440.c
  mini2440/button-target.h
  mini2440/lcd-target.h
  mini2440/led-mini2440.c
  mini2440/led-mini2440.h
  mini2440/power-mini2440.c
   ver2.patch (101.4 KiB)
jdgordon commented on 2009-10-14 00:58

good news….. mine came today so ill aim to get this commited some time this week (tonight even maybe).

thanks for moving it to mini2440/ instead of lyre…

jdgordon commented on 2009-10-14 05:15

looks good…. the button defines look a bit odd, but if those values mean anything then so be it… also, the actual BUTTON_* names are bad… they should be BUTTON_ONE through to BUTTON_SIX, and then do #define BUTTON_LEFT BUTTON_ONE (or whatever) and do the same for RIGHT, (I tihnk they are the only ones actually required, the rest are used to map to ACTION_ values

someone with a beat f/x needs to double check those drivers before it can be checked in…

BobC commented on 2009-10-19 11:00

Updated patch - rebased to Rockbox latest, fix errors in lcd-target.h, update debug-target.h

   ver3c.patch (105.8 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing