- Status Closed
- Percent Complete
- Task Type Bugs
- Category Codecs
-
Assigned To
Buschel - Operating System iPod 5G
- Severity Low
- Priority Very Low
- Reported Version Release 3.4
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#10637 - Error after MPC file
When you will try to play Muspack (mpc) song encoded by last version of Muspack encoder (1.30.0) (SV8 file) wich will not play because SV8 MPC files are not supported by rockbox right now - the rockbox is not able to play any other song until reboot.
Example: http://rapidshare.com/files/288101293/random.mpc
Closed by Buschel
2010-03-07 20:29
Reason for closing: Fixed
Additional comments about closing:
2010-03-07 20:29
Reason for closing: Fixed
Additional comments about closing:
Closed as sv8 is supported from
r25057.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Rockbox doesn’t support SV8 because theres no SV8 decoder.
I know that this file is not supported, but the Rockbox is loosing stability when it is trying to play it. And after that you can’t open any other files like mp3, wma, etc…
You’re right I’m not sure how I misunderstood you so completely. I will look at this today.
When working on this bug I got really confused. First I very quickly found out that the header parsing is not correct for the final sv8 bitstream release. The attached patch corrects the mpc header parsing. Neverthless the error still occurs.
Some more details:
1. As soon as a single mpc-file was selected that results “false” in metadata.c (case AFMT_MPC:), the mpc-codec quits (which is correct) and afterwards playback is totally blocked.
2. If I change the code in apps/metadata/mpc.c to return “true” for sv8-files, everything works fine. In this case the playback of this file is rejected within the codec-loop. In this case the playback is not blocked afterwards.
3. Playback is only blocked after a broken track is selected that is not the last in the current playlist!
4. This is also happening with mpa-files.
Any suggestions from the codec engine experts?
I opened up a new bug report (
FS#10930) as this is not only relevant for mpc, but will happen with each non-playable/corrupted audio file.Sumitted parser bugfix with r24408. Nevertheless a fix of
FS#10930is needed to really fix the blocking of the playback engine.Will be fixed with commit of
FS#11079(full mpc sv8 support).