Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To
    tomers
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2009-10-04
Last edited by tomers - 2009-10-05

FS#10650 - Right-to-left menus support for Hebrew and Arabic

This patch changes list direction to RTL when Hebrew or Arabic languages are loaded.

It does so by adding an options field to the lang file (as a result, the lang file version is incremented). The <options> element in the lang file currently supports only one field - rtl (right-to-left) which is set in the Hebrew and Arabic language files. Other files need not change.

At the moment, this patch breaks some less common screens.
This is a preliminary work. It still needs lots of development.

Closed by  tomers
2009-10-05 21:06
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r22945

sweet! just one quick thing… using display→getwidth() IIRC will cause you problems if the user uses a custom viewport for the lists…

trying it out now… great work!!
Should the left/right buttons be switched also? I’m thinking that LTR pressing right is the accept/enter action which sort of feels backwards in RTL?
also, ignore my previous comment about getwidth… just checked and its safe. :)

code style… this line tripped me out for a minute… “bool ltr = !lang_is_rtl();” thats just damn confusing… either have it both ltr or both rtl.. mixing them is hard to read and is guaranteed to cause problems later.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing