Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fg - 2009-10-07
Last edited by fg - 2009-10-07

FS#10660 - add database tool to configure

This patch adds support for building the database tool to configure, as a first step to get it in the autobuild system.

The only variables for the database tool should be endianness and charcell/bitmap, so allowing to build it per target may be seen as overkill.

(charcell/bitmap matters because unicode handling is different between those)

   db.patch (6.7 KiB)
Closed by  fg
2009-10-07 18:17
Reason for closing:  Accepted
Additional comments about closing:  

r22998

Admin
fg commented on 2009-10-07 13:18

Now also builds properly for HWCODEC.

The patch also includes a semi-unrelated fix to configure that works around a recent gcc bug by not setting advanced optimisation flags for host-side tools (previously they were set the same as for the corresponding crosscompiler)

I remember mentioning this on IRC a while back and getting at least no negative comments: I’d prefer to move all of those options out of configure and instead having it as a build target. This already works for the manual: configure as (N)ormal, then use “make manual”. Having this for all other tools might be more convenient, especially for users, as one could simply run “make rockbox zip manual checkwps database” or similar.

Admin
fg commented on 2009-10-07 14:07

I don’t disagree, but I’m not sure how well the build system will handle this. Various *.make files set CFLAGS and similar, so always including them all may cause strange effects.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing