Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Junio C Hamano - 2009-10-12
Last edited by Thomas Martitz - 2009-10-15

FS#10673 - [PATCH] apps/gui/skin_engine/skin_tokens.c: Fix %Sp expansion in wps

[PATCH] apps/gui/skin_engine/skin_tokens.c: Fix %Sp expansion in wps

The value returned from sound_get_pitch() was shown assuming that 100%
corresponds to 1000 by skin_tokens.c::get_token_value(). The value
actually is 100*PITCH_SPEED_PRECISION.

Steal the way the callchain from gui_syncpitchscreen_run() to
pitchscreen_draw() in apps/gui/pitchscreen.c formats the value and use it
here for consistency.

Closed by  Thomas Martitz
2009-10-15 22:24
Reason for closing:  Accepted
Additional comments about closing:  

Aplied in r23199. Thanks

Junio C Hamano commented on 2009-10-12 22:05

Sorry, it seems that I failed to attach the patch.

Thomas Martitz commented on 2009-10-15 22:24

Hehe, I almost git svn dcommit’ed it directly, but the path in the description and the fact that you’re missing from docs/CREDITS prevented it :)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing