• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Playlists
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mitk - 2009-10-24
Last edited by stripwax - 2009-10-28

FS#10717 - Add PLAYLIST_INSERT_LAST_SHUFFLED functionality to onplay menu

This will Add PLAYLIST_INSERT_LAST_SHUFFLED functionality to onplay menu.
It mostly works but still needs testing. For example it is doesn’t make sense when playlist is empty or we are inserting just one track and doesn’t need to be displayed in such cases.
My question is: clean it further or leave it?

Closed by  stripwax
2009-10-28 22:28
Reason for closing:  Accepted
mitk commented on 2009-10-24 17:55

Forgot patch file.

You also forgot the explain what PLAYLIST_INSERT_LAST_SHUFFLED is supposed to do. At least I didn’t get it.

mitk commented on 2009-10-24 21:15

Simply: You can add shuffled tracks to the end of dynamic playlist. Without this patch you can add tracks to the end of playlist, but not shuffled.

looks good… I tihnk its missing stuff so it adds the tracks to the .playlist_control file though?

mitk commented on 2009-10-25 08:11

Yes, it adds also to .playlist_control. In fact it uses “playlist API” and is doing everything same way like other playlist manipulating commands.

mitk commented on 2009-10-25 09:58

Tested and ready to commit version. Diff against r23340.

mitk commented on 2009-10-28 10:54

Added patch to manual also.

mitk commented on 2009-10-28 13:31

There is no make sense to display insert_last_shuffled option when just one track is selected.
Also some comments added.



Available keyboard shortcuts


Task Details

Task Editing