Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by teru - 2009-10-25
Last edited by teru - 2009-10-27

FS#10722 - some improvements for gui/list.c

this patch is some improvements for gui/list.c
* add function list_get_nb_lines and replace duplicated codes to calculate number of lines by it.
* refine calculation of gui_list→start_item[screen] in function gui_list_put_selection_on_screen.
- tries to show as many items as possible. hopefully fix  FS#10054  without further glitches, iiuc the issue.
* remove trailing spaces and fix indents.

   improve-gui-list.patch (15.9 KiB)
Closed by  teru
2009-10-27 13:35
Reason for closing:  Accepted
Additional comments about closing:  

committed in r23367

kugel. commented on 2009-10-25 18:50

If you want your patches reviewed (which I assume you do if you upload it here), then please separate indention & space fixes from actual code changes to make reviewing easier.

I'll have a look if nobody beats me to it, but remember the above for future patches.

teru commented on 2009-10-26 11:05

I'm sorry. this is one without changes of spaces.

   improve-gui-list.2.patch (6.2 KiB)
kugel. commented on 2009-10-26 11:29

Thanks! Much easier to review now.

The patch looks very good. I assume it works, so go for it :)

On a unrelated note: gui_synclist_item_is_onscreen() seems to only check the lower bound of the visible list, not the upper. Is that correct? I don't think so. But that's not related to your patch.

teru commented on 2009-10-26 13:39

quick fix of gui_synclist_item_is_onscreen. the function doesn't used as far as i greped.

   improve-gui-list.3.patch (6.2 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing