Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Rbutil
  • Assigned To
    tomers
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2009-10-31
Last edited by tomers - 2009-11-01

FS#10747 - Disable actions if rbutil is not configured properly

This patch disables all actions if rbutil is not configured yet.
It also adds disabling of menu items which were not disabled whenever their corresponding buttons got disabled.

Closed by  tomers
2009-11-01 17:16
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r23466

This doesn’t work: bootloadermethod=none does *not* mean that it’s not configure but that no bootloader is required. This is the bootloader method used for the archos line, and disabling installation in this case will disable installation for archos players.

Also, while the original idea is good I think this doesn’t go far enough. If the configuration is wrong then there’s no point in having the whole tab widget active at all – if the configuration is invalid you can’t install anything else either.

- Control both buttons and menu items enable state according to whether user configuration is valid.
- On load, set the selected tab to be the first tab, instead of the extras tab.
- Disable the whole tabs widget and Actions menu item if rbutil is not configured properly

This patch does not contains the irrelevant remark line change slipped through previously.

I like the idea of this patch. And i really applaud to tomers for helping out with rbutil.

But i think the condition for bootloader_removable is not correct. We should check the flags of the bootloaderinstall class to see if it can remove the bootloader. And not just check for fwpatcher or none as install method.

I don’t see the effect that the tab initially being active after startup is the Extras tab. Have you possibly modified the rbutilqtfrm.ui file? This file controls the default until explicitly set by the application. As this also generated code for setting the active tab it should be done in the ui file if possible.

Another try.
- Removed setting active tab (there was no such issue, afterall).
- Renamed status variables to better match their intention.
- Add TODO comment for further work that needs to be done with regard of reading bootloader capabilities from the bootloader’s own capabilities flag, and not from the settings.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing